feat: add number_of_employees field to Profile API#313
Draft
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Draft
feat: add number_of_employees field to Profile API#313Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Conversation
Adds an optional `number_of_employees` string field to the Profile create API and documents it in the update params comment, mirroring the recently added `doing_business_as` field. No client-side enum validation; the server validates the allowed values. Bumps version to 4.60.3 and updates tests, fixtures, and changelog. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new optional
number_of_employeesstring field to the Profile (10DLC/A2P account profile)createAPI, and documents it in theupdateparams comment. This mirrors the recently shippeddoing_business_asfield and matches a corresponding backend change in campaign-service.There is no client-side enum validation — any string is accepted and the server validates the value (same handling as
doing_business_asandbusiness_contact_email).Allowed values (server-validated, documented in a code comment)
BETWEEN_1_AND_10BETWEEN_11_AND_50BETWEEN_51_AND_200BETWEEN_201_AND_500BETWEEN_501_AND_2000BETWEEN_2001_AND_10000MORE_THAN_10001Changes
plivo/resources/profile.py: added field tocreate@validate_args(optional string) and method signature (default''), updatedupdateparams comment.doing_business_as.🤖 Generated with Claude Code